ganeshmurthy commented on a change in pull request #1536:
URL: https://github.com/apache/qpid-dispatch/pull/1536#discussion_r826045500
##########
File path: dockerfiles/Dockerfile-ubuntu
##########
@@ -16,14 +16,17 @@
# specific language governing permissions and limitations
# under the License.
#
+
# Copy this docker file to your local folder. Build the docker file like this
- sudo docker build -t <username>/dispatch --file=Dockerfile-ubuntu . (don't
miss the dot at the end)
# To run it - sudo docker run -i -t <username>/dispatch (this will launch the
dispatch router)
-# Gets the trusty Ubuntu from dockerhub
-FROM ubuntu:latest
+# Gets the Ubuntu from dockerhub
+FROM docker.io/library/ubuntu:focal
Review comment:
Yes, let's leave the FROM line as it was before except just change
latest to focal. Ideally, if
https://issues.apache.org/jira/browse/DISPATCH-2337 was fixed, then there would
be no need to change this line but as you say for now focal is ok. Leave the
docker.io/library out of it.
If you are also fixing the fedora dockerfile in this PR, then please change
the JIRA description to say fedora as well. Since the centos dockerfile is also
being fixed in this PR and dockerfiles/Dockerfile-fedora-only-python3 is being
deleted, maybe the JIRA should be more generic like "Fix the dockerfiles in the
dockerfiles folder" or something.
Also commit message is missing a colon after the JIRA number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
