[ 
https://issues.apache.org/jira/browse/QPIDJMS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510849#comment-17510849
 ] 

Timothy A. Bish commented on QPIDJMS-567:
-----------------------------------------

That would provide a even larger amount of log spam than it already produces 
when the provider is functioning within normal expectations, mainly 
reconnecting when the connection is dropped.  There is rarely a good case for 
logging exception stack traces at an information level and I wouldn't really 
say this is one of them. 

> The FailoverProvider does not report the root cause of a connection attempt 
> failure
> -----------------------------------------------------------------------------------
>
>                 Key: QPIDJMS-567
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-567
>             Project: Qpid JMS
>          Issue Type: Bug
>          Components: qpid-jms-client
>            Reporter: Philippe Haution
>            Priority: Major
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> {{In the FailoverProvider.triggerReconnectionAttempt() method, in case the 
> connection attempt fails, we end up in a catch block where the Throwable that 
> explains the problem is not logged to the user.}}
> Instead of :
> {quote}catch (Throwable e) {
>   LOG.info("Connection attempt:[{}] to: {} failed", reconnectAttempts,
>            target.getScheme() + "://" + target.getHost() + ":" + 
> target.getPort());
> {quote}
> We should have:
> {quote}catch (Throwable e) {
>   LOG.info("Connection attempt:[{}] to: {} failed", reconnectAttempts,
>            target.getScheme() + "://" + target.getHost() + ":" + 
> target.getPort(), e);
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to