[
https://issues.apache.org/jira/browse/QPIDJMS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511208#comment-17511208
]
Philippe Haution commented on QPIDJMS-567:
------------------------------------------
I do not know why we have an info level log in this catch block, I would expect
it to be at least at warning level, but anyway swallowing an exception is also
rarely a good thing, in that specific case it denied the developer the chance
to understand what the root cause of the failed connection attempt was. I
cannot consider that additional piece of information as spam.
> The FailoverProvider does not report the root cause of a connection attempt
> failure
> -----------------------------------------------------------------------------------
>
> Key: QPIDJMS-567
> URL: https://issues.apache.org/jira/browse/QPIDJMS-567
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
> Reporter: Philippe Haution
> Priority: Major
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> {{In the FailoverProvider.triggerReconnectionAttempt() method, in case the
> connection attempt fails, we end up in a catch block where the Throwable that
> explains the problem is not logged to the user.}}
> Instead of :
> {quote}catch (Throwable e) {
> LOG.info("Connection attempt:[{}] to: {} failed", reconnectAttempts,
> target.getScheme() + "://" + target.getHost() + ":" +
> target.getPort());
> {quote}
> We should have:
> {quote}catch (Throwable e) {
> LOG.info("Connection attempt:[{}] to: {} failed", reconnectAttempts,
> target.getScheme() + "://" + target.getHost() + ":" +
> target.getPort(), e);
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
