Jmennius commented on PR #1550:
URL: https://github.com/apache/qpid-dispatch/pull/1550#issuecomment-1099214496
> > 1. should be web console be enabled by default?
>
> imo no
>
> > 2. we're fine with `RelWithDebInfo` (default) or should we switch to
`Release`?
>
> RelWithDebInfo is used everywhere, nobody ever uses Release with dispatch,
as far as I know
>
> > 3. is it worth adding `$(if [ "${enable_console}" = "ON" ]; then echo
"npm"; fi)` to apt-get invocation on build stage to avoid installing `npm` when
it is not required during build? (does not influence runtime image)
>
> maybe, yes. If you put it on its own line, then it makes sense to me; of
course, it complicates build... up to you, I think
Thanks. If console stays disabled by default - I'll add that condition then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
