[GitHub] [qpid-dispatch] bartoval commented on a diff in pull request #1560: DISPATCH-2339: Update react-scripts to 5; add CRACO to reapply polyfills

Thu, 21 Apr 2022 06:14:41 -0700 


bartoval commented on code in PR #1560:
URL: https://github.com/apache/qpid-dispatch/pull/1560#discussion_r855165802


##########
console/react/package.json:
##########
@@ -58,6 +63,7 @@
     ]
   },
   "devDependencies": {
+    "@craco/craco": "^7.0.0-alpha.3",

Review Comment:
   If you prefer to use the dist version of the files (dist/rhea.min, js, or 
rhea.js) you need to load them as a standalone library in the publc/index.html.
   
   1) npm uninstall rhea
   2) move the dist lib to the public folder of the project.
   
![1](https://user-images.githubusercontent.com/79913332/164464454-d2677b18-db42-42f0-b6e1-0c44cf1b8730.png)
   
   3)in index.html load the lib and attach it to the window object, so you can 
reuse it
   
![2](https://user-images.githubusercontent.com/79913332/164464395-d22209df-67e9-46dd-b283-585ced918ff0.png)
   
   4) use it in connection.js
   ![Screenshot from 2022-04-21 
15-13-57](https://user-images.githubusercontent.com/79913332/164465744-bd80c392-6f8b-4fff-b71b-1a08e619e1df.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to