vavrtom commented on code in PR #121:
URL: https://github.com/apache/qpid-broker-j/pull/121#discussion_r893482694
##########
broker-plugins/broker-query-engine/src/main/java/org/apache/qpid/server/query/engine/QueryEngine.java:
##########
@@ -112,6 +111,10 @@ public void setMaxBigDecimalValue(final BigDecimal
maxBigDecimalValue)
_maxBigDecimalValue = maxBigDecimalValue;
}
+ public void setMaxQueryCacheSize(final int maxQueryCacheSize) {
Review Comment:
The curly bracket should be on new line.
##########
broker-plugins/broker-query-engine/src/main/java/org/apache/qpid/server/query/engine/evaluator/settings/QuerySettings.java:
##########
@@ -63,12 +62,12 @@
/**
* Maximal amount of queries allowed caching
*/
- private int _maxQueryCacheSize = HttpPort.DEFAULT_QUERY_ENGINE_CACHE_SIZE;
+ private int _maxQueryCacheSize = 1000;
Review Comment:
The default value constant could be defined in this class (or in some other
class in query engine plugin) and reused in HttpManagementConfiguration to
avoid duplication of default values.
##########
broker-plugins/broker-query-engine/src/main/java/org/apache/qpid/server/query/engine/evaluator/settings/QuerySettings.java:
##########
@@ -63,12 +62,12 @@
/**
* Maximal amount of queries allowed caching
*/
- private int _maxQueryCacheSize = HttpPort.DEFAULT_QUERY_ENGINE_CACHE_SIZE;
+ private int _maxQueryCacheSize = 1000;
/**
* Maximal amount of query tree nodes allowed
*/
- private int _maxQueryDepth = HttpPort.DEFAULT_QUERY_ENGINE_MAX_QUERY_DEPTH;
+ private int _maxQueryDepth = 4096;
Review Comment:
The default value constant could be defined in this class (or in some other
class in query engine plugin) and reused in HttpManagementConfiguration to
avoid duplication of default values.
##########
broker-plugins/broker-query-engine/src/main/java/org/apache/qpid/server/query/engine/evaluator/settings/QuerySettings.java:
##########
@@ -78,7 +77,7 @@
/**
* ZoneId used in date/time representation
*/
- private ZoneId _zoneId = ZoneId.of(HttpPort.DEFAULT_QUERY_ENGINE_ZONE_ID);
+ private ZoneId _zoneId = ZoneId.of("UTC");
Review Comment:
The default value constant could be defined in this class (or in some other
class in query engine plugin) and reused in HttpManagementConfiguration to
avoid duplication of default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
