astitcher commented on PR #446: URL: https://github.com/apache/qpid-proton/pull/446#issuecomment-4578675189
One issue with this fix is that it just omits printing the auth details as if they weren't even there - for proper debugability of authentication issues you really should be able to see that they were there but mask them from logging. Is the username actually sensitive info that needs to be masked? If so maybe only giving a few characters not all might be better for being able to correlate logged authentication attempts. I also wonder if the correct place for this is actually in the __repr__ dunder for the Url object instead of here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
