kserin commented on PR #446: URL: https://github.com/apache/qpid-proton/pull/446#issuecomment-4593041155
Thanks for the feedback. I updated the PR. I've moved the fix into Url._netloc() (and by extension __str__/__repr__) rather than at the log call site, as you suggested. This way any code that converts a Url to a string automatically gets the masked version. For the username, I agree it's not really sensitive information, so it's left in clear and this also helps correlate authentication attempts in logs as you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
