coolkaito commented on PR #453: URL: https://github.com/apache/qpid-broker-j/pull/453#issuecomment-6332169855
@dakirily Thank you for the review. The AMQP 0-10 regression was addressed. As for the heartbeat issue, I would assess the provided fix only as partial: when write backpressure fills the output buffer, the broker can stop reading incoming heartbeats while the read-idle timer continues running, potentially closing an active connection. But described behavior predates the current PR. I would suggest to fix it with a separate JIRA and PR to keeps current CPU-spin fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
