dakirily commented on PR #453: URL: https://github.com/apache/qpid-broker-j/pull/453#issuecomment-6345812189
I agree that the heartbeat issue can be fixed with the follow-up JIRA / PR to keep this change focused. Feel free to create such follow-up JIRA. As for this change I would ask you to verify the new unit tests - some of them have Thread.sleep() calls, which I would prefer to avoid. Please replace those calls with countdown latches or other java concurrency utilities to make the tests deterministic. Otherwise I have no further comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
