----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/520/#review351 -----------------------------------------------------------
Re why we didn't do class-level exports for the original Windows work, it was mainly to avoid creeping externs where we didn't want them. In Visual C++ if you declspec(dllexport) a class, all ancestors also have to be declspec(dllexport). I think there was also an issue with Boost and templates related to this, but I can't find the info I was looking for on it so may not be right. For the Visual C++ info, also see http://msdn.microsoft.com/en-us/library/81h27t8c%28v=VS.90%29.aspx - Steve On 2011-03-22 15:24:43, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/520/ > ----------------------------------------------------------- > > (Updated 2011-03-22 15:24:43) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Summary > ------- > > WIP: Enable -fvisibility=hidden, libraries export only public symbols > > Making progress. Working thru remaining link errors. > > - I seem to need class level EXTERN decls to resolve undefined > vtable/typeinfo. > - need to ensure throwable types have extern typeinfo - need class level > EXTERN? > > > Diffs > ----- > > trunk/qpid/cpp/configure.ac 1084053 > trunk/qpid/cpp/include/qmf/ImportExport.h 1084053 > trunk/qpid/cpp/include/qmf/engine/QmfEngineImportExport.h 1084053 > trunk/qpid/cpp/include/qpid/CommonImportExport.h 1084053 > trunk/qpid/cpp/include/qpid/Exception.h 1084053 > trunk/qpid/cpp/include/qpid/ImportExportDefs.h PRE-CREATION > trunk/qpid/cpp/include/qpid/RangeSet.h 1084053 > trunk/qpid/cpp/include/qpid/agent/QmfAgentImportExport.h 1084053 > trunk/qpid/cpp/include/qpid/client/ClientImportExport.h 1084053 > trunk/qpid/cpp/include/qpid/console/ConsoleImportExport.h 1084053 > trunk/qpid/cpp/include/qpid/framing/SequenceNumber.h 1084053 > trunk/qpid/cpp/include/qpid/framing/SequenceSet.h 1084053 > trunk/qpid/cpp/include/qpid/messaging/ImportExport.h 1084053 > trunk/qpid/cpp/include/qpid/sys/IOHandle.h 1084053 > trunk/qpid/cpp/include/qpid/sys/posix/Mutex.h 1084053 > trunk/qpid/cpp/include/qpid/sys/posix/PrivatePosix.h 1084053 > trunk/qpid/cpp/include/qpid/types/ImportExport.h 1084053 > trunk/qpid/cpp/src/Makefile.am 1084053 > trunk/qpid/cpp/src/qmf.mk 1084053 > trunk/qpid/cpp/src/qpid/broker/BrokerImportExport.h 1084053 > trunk/qpid/cpp/src/qpid/sys/rdma/ImportExport.h PRE-CREATION > trunk/qpid/cpp/src/qpid/sys/rdma/RdmaIO.h 1084053 > trunk/qpid/cpp/src/qpid/sys/rdma/rdma_wrap.h 1084053 > > Diff: https://reviews.apache.org/r/520/diff > > > Testing > ------- > > > Thanks, > > Alan > >
