> On 2011-05-30 18:36:30, Andy Goldstein wrote: > > /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h, line 45 > > <https://reviews.apache.org/r/791/diff/2/?file=19793#file19793line45> > > > > I don't think this method is needed any more
Yep > On 2011-05-30 18:36:30, Andy Goldstein wrote: > > /trunk/qpid/cpp/src/qpid/broker/Message.cpp, line 379 > > <https://reviews.apache.org/r/791/diff/2/?file=19795#file19795line379> > > > > The expiration time should be calculated using the cluster clock (via > > e.getCurrentTime()), not the broker's local system clock...right? > > Otherwise, each node may think the message expires at a different time, > > leading to inconsistencies. It looks like this is done in adjustTtl, but > > not here. Yikes! I'll review the changes carefully to make sure I didn't slip up anywhere else and post a new patch. > On 2011-05-30 18:36:30, Andy Goldstein wrote: > > /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h, line 47 > > <https://reviews.apache.org/r/791/diff/2/?file=19793#file19793line47> > > > > I don't think this method is needed any more Yep - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/791/#review735 ----------------------------------------------------------- On 2011-05-30 17:44:11, Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/791/ > ----------------------------------------------------------- > > (Updated 2011-05-30 17:44:11) > > > Review request for qpid, Andrew Stitcher, Alan Conway, and Gordon Sim. > > > Summary > ------- > > QPID-3280: When sending a large number of messages with nonzero TTLs to a > cluster, overall message throughput drops by around 20-30% compared to > messages with TTL 0. > > Replaced the complicated message expirly logic in the cluster with a simpler > "cluster clock" for expiry of messages with TTL. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1128070 > /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h 1128070 > /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.cpp 1128070 > /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1128070 > /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.h 1128070 > /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.cpp 1128070 > /trunk/qpid/cpp/src/qpid/cluster/Cluster.h 1128070 > /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1128070 > /trunk/qpid/cpp/src/qpid/cluster/ClusterPlugin.cpp 1128070 > /trunk/qpid/cpp/src/qpid/cluster/ClusterSettings.h 1128070 > /trunk/qpid/cpp/src/qpid/cluster/ClusterTimer.cpp 1128070 > /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1128070 > /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1128070 > /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.h 1128070 > /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.cpp 1128070 > /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1128070 > /trunk/qpid/cpp/src/qpid/sys/Timer.h 1128070 > /trunk/qpid/cpp/src/qpid/sys/Timer.cpp 1128070 > /trunk/qpid/cpp/src/tests/QueueTest.cpp 1128070 > /trunk/qpid/cpp/xml/cluster.xml 1128070 > /trunk/qpid/python/examples/api/spout 1128070 > > Diff: https://reviews.apache.org/r/791/diff > > > Testing > ------- > > > Thanks, > > Alan > >
