----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/791/ -----------------------------------------------------------
(Updated 2011-06-01 17:58:05.198586) Review request for qpid, Andrew Stitcher, Alan Conway, Gordon Sim, and Andy Goldstein. Changes ------- Changes: - Gordons suggestion for Message::adjustTtl - Removed python logging noise from tests. - Fixed some test race conditions. Summary ------- QPID-3280: When sending a large number of messages with nonzero TTLs to a cluster, overall message throughput drops by around 20-30% compared to messages with TTL 0. Replaced the complicated message expirly logic in the cluster with a simpler "cluster clock" for expiry of messages with TTL. Diffs (updated) ----- /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1128070 /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h 1128070 /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.cpp 1128070 /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1128070 /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.h 1128070 /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.cpp 1128070 /trunk/qpid/cpp/src/qpid/cluster/Cluster.h 1128070 /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1128070 /trunk/qpid/cpp/src/qpid/cluster/ClusterPlugin.cpp 1128070 /trunk/qpid/cpp/src/qpid/cluster/ClusterSettings.h 1128070 /trunk/qpid/cpp/src/qpid/cluster/ClusterTimer.cpp 1128070 /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1128070 /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1128070 /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.h 1128070 /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.cpp 1128070 /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1128070 /trunk/qpid/cpp/src/qpid/sys/Timer.h 1128070 /trunk/qpid/cpp/src/qpid/sys/Timer.cpp 1128070 /trunk/qpid/cpp/src/tests/QueueTest.cpp 1128070 /trunk/qpid/cpp/src/tests/cluster_tests.py 1128070 /trunk/qpid/cpp/xml/cluster.xml 1128070 Diff: https://reviews.apache.org/r/791/diff Testing ------- Thanks, Alan
