----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/791/ -----------------------------------------------------------
(Updated 2011-06-03 20:30:03.292570) Review request for qpid, Andrew Stitcher, Alan Conway, Gordon Sim, and Andy Goldstein. Summary (updated) ------- QPID-3280: Efficient handling of TTL by cluster WIP: Use atomic counter and period in place of RateTracker for QueueCleaner. RateTracker was using the non-cluster clock to decide to run purges or not. This is a clock-free solution that gives the same result and is safe in cluster. WIP: agoldste's expiration replication fix. QPID-3280: Fixed extra failover update messages on brokers joining the cluster. QPID-3280: When sending a large number of messages with nonzero TTLs to a cluster, overall message throughput drops by around 20-30% compared to messages with TTL 0. Replaced the complicated message expirly logic in the cluster with a simpler "cluster clock" for expiry of messages with TTL. Diffs ----- /trunk/qpid/cpp/managementgen/Makefile.am 1128070 /trunk/qpid/cpp/src/CMakeLists.txt 1131084 /trunk/qpid/cpp/src/Makefile.am 1131084 /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1131084 /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h 1131084 /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.cpp 1131084 /trunk/qpid/cpp/src/qpid/broker/Message.h 1131084 /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1128070 /trunk/qpid/cpp/src/qpid/broker/Queue.h 1131084 /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1131084 /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.h 1131084 /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.cpp 1131084 /trunk/qpid/cpp/src/qpid/broker/RateTracker.h 1131084 /trunk/qpid/cpp/src/qpid/broker/RateTracker.cpp 1131084 /trunk/qpid/cpp/src/qpid/cluster/Cluster.h 1131084 /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1131084 /trunk/qpid/cpp/src/qpid/cluster/ClusterPlugin.cpp 1131084 /trunk/qpid/cpp/src/qpid/cluster/ClusterSettings.h 1131084 /trunk/qpid/cpp/src/qpid/cluster/ClusterTimer.cpp 1131084 /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1131084 /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1131084 /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.h 1131084 /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.cpp 1131084 /trunk/qpid/cpp/src/qpid/cluster/FailoverExchange.h 1131084 /trunk/qpid/cpp/src/qpid/cluster/FailoverExchange.cpp 1131084 /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1131084 /trunk/qpid/cpp/src/qpid/sys/Timer.h 1131084 /trunk/qpid/cpp/src/qpid/sys/Timer.cpp 1131084 /trunk/qpid/cpp/src/tests/QueueTest.cpp 1131084 /trunk/qpid/cpp/src/tests/cluster_test_logs.py 1131084 /trunk/qpid/cpp/src/tests/cluster_tests.py 1131084 /trunk/qpid/cpp/xml/cluster.xml 1131084 Diff: https://reviews.apache.org/r/791/diff Testing ------- Thanks, Alan
