[
https://issues.apache.org/jira/browse/QPID-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099016#comment-13099016
]
Andrew Stitcher commented on QPID-3464:
---------------------------------------
I note that the diffs seem to be against 0.10 so there is some chance they
don't apply cleanly against trunk.
[BTW it would probably be easier to review these changes if you made a review
board review as I'd get a bit more context there]
Specifically I'm a little unclear about some of the cmake changes:
* Introduced a help2man build in docs/man (and done a neat jobs of it) however
we've actually stopped doing this build entirely from our current build.
However it's unfortunately not removed completely yet though so this work isn't
currently useful to us.
* Removed Boost libs from the detection list that are required on windows even
though they are not required on unix - there is even a comment just above
explaining this.
* This change:
- else (CMAKE_SYSTEM_NAME STREQUAL Windows)
+ else (CMAKE_SYSTEM_NAME STREQUAL Linux)
In ssl.cmake just looks wrong to me and I wonder if its ever been run, as it
should make cmake give an error (CMake cares about matching the "if" parameters
with the "else" parameters and gives an error if they don't match but the
corresponding "if" hasn't changed.
* Added unconditional pragmas into the code to deal with warnings from the
boost library, but this must either depend on boost version or the compiler
version and so should be much more tightly constrained with appropriate ifdefs
and comments that explain when you need to turn these warnings off. And
preferably they should be turned off only for the shortest time that's
necessary - I suspect it's a template instantiation that causes the problem so
this might be hard.
Having made these detailed comments, on the whole this is a very good piece of
work and neatens some things a lot. It looks like it moves in the direction of
cmake build parity too which is a big plus.
> Fix QPID Build on Debian Squeeze
> --------------------------------
>
> Key: QPID-3464
> URL: https://issues.apache.org/jira/browse/QPID-3464
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.12
> Environment: Debian Squeeze
> Reporter: Jan-Marek Glogowski
> Priority: Minor
> Attachments: 01_build-libqmfengine-before-libqmf.diff,
> 02_configure.ac-fix-polling-detection.diff,
> 03_install-python-libs-into-PYTHON_LIB.diff,
> 04_reorganize-automake-qpid-perl-bindings-build.diff,
> 05_cleanup-cmake-build.diff, 06_fix-ignored-return-value-warnings.diff
>
>
> I'm using serveral patches to build QPID on Debian Squeeze.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
