[
https://issues.apache.org/jira/browse/QPID-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101128#comment-13101128
]
Jan-Marek Glogowski commented on QPID-3464:
-------------------------------------------
Thanks for the comments. I've attached an additional patch which
* fixes another ssl.cmake CnP error,
* changes the strerror calls to strError,
* distinguishes between Linux and Windows on find_package(Boost ...)
* makes the pragma code depend on GCC >= 4.2.
(at least it's the first time documented in the gcc pragma docs in v4.2)
Comments:
| Use review board
I've created an account on reviews.apache.org (which was hard to find).
* Should I upload a combined patch to reviewboard?
* What is the "Base Directory"? (if I generate a patch using git diff, base is
'/' ?)
Probably someone can add some additional information to the _Patch Submission_
paragraph on http://qpid.apache.org/qpid_project_etiquette_guide.html and also
including a link to JIRA.
|* Introduced a help2man build in docs/man ...
What's the preferred way to build the manpages? There is the
cpp/docs/man/generate_manpage script, which calls sed...
|* Removed Boost libs from the detection list ...
Fixed
|* ssl.cmake changes (else (CMAKE_SYSTEM_NAME STREQUAL Windows))
My ssl.cmake change is correct; the else block contains the linux ssl build
code. The original code was:
{quote}
if (CMAKE_SYSTEM_NAME STREQUAL Windows)
else (CMAKE_SYSTEM_NAME STREQUAL Windows)
endif (CMAKE_SYSTEM_NAME STREQUAL Windows)
{quote}
|* Added unconditional pragmas ...
Fixed
|In the 06 patch there are a number of uses of strerror() ...
Fixed
|The poller selection patch (02)
I'm currently building using cmake. I used this patch to allow auto-selection
of the poller code, when I build QPID using autotools. I don't care if the
patch won't be accepted - it just seemed convenient.
|Patches apply to trunk fine for me and build and test passes. One comment is
that the --prefix option to configure is no longer sufficient ...
PYTHON_LIB is set in the configure.ac file AC_SUBST'ed as [Directory to install
python bindings in].
Maybe it's better to use pythondir from AM_PATH_PYTHON (cpp/m4/python.m4),
which uses PYTHON_PREFIX, which is set to '${prefix}' and drop all the
PYTHON_LIB code fom configure.ac?
> Fix QPID Build on Debian Squeeze
> --------------------------------
>
> Key: QPID-3464
> URL: https://issues.apache.org/jira/browse/QPID-3464
> Project: Qpid
> Issue Type: Improvement
> Components: Build Tools
> Affects Versions: 0.12
> Environment: Debian Squeeze
> Reporter: Jan-Marek Glogowski
> Priority: Minor
> Attachments: 01_build-libqmfengine-before-libqmf.diff,
> 02_configure.ac-fix-polling-detection.diff,
> 03_install-python-libs-into-PYTHON_LIB.diff,
> 04_reorganize-automake-qpid-perl-bindings-build.diff,
> 05_cleanup-cmake-build.diff, 06_fix-ignored-return-value-warnings.diff
>
>
> I'm using serveral patches to build QPID on Debian Squeeze.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
