[
https://issues.apache.org/jira/browse/QPID-3532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131835#comment-13131835
]
Rajith Attapattu commented on QPID-3532:
----------------------------------------
What kind of testing has been done on this patch?
Has there been any testing done in a clustered setup?
This change obviously impacts any failover operation. Given that failover is
our Achilles heel and that the Failover mutex being a source of many race
conditions and deadlocks, I'm quite concerned about making this change just
before the deadline.
I am also concerned that certain changes made in the last week have been backed
out, giving the impression that we've been hurried by the looming deadline.
Perhaps we will benefit by taking more time to think through and verify these
changes and target these fixes for our next release.
Also what would be beneficial is a summary of changes being done on the client.
It's true we discussed the issues and possible solutions. But I think it's
equally important to have an outline of the code changes being made especially
given that they were made very close to the release. This makes it easy for
anybody reviewing those changes.
Again given the fact that we don't have quality tests to verify these changes
with confidence, I'm of the opinion that we make these changes after the 0.14
release.
Regards,
Rajith
> Fix the blocking of JMS operations when failover happens
> --------------------------------------------------------
>
> Key: QPID-3532
> URL: https://issues.apache.org/jira/browse/QPID-3532
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: 0.13
>
> Attachments:
> QPID-3532-make-the-0-10-client-hold-the-failover-mutex-during-failover.patch
>
>
> When connection is lost and failover is started the Qpid Client should block
> on invocation of JMS operations which require sending or receiving data over
> the network.
> With current implementation the performing of certain operations during
> failover can lead to unexpected behaviour.
> For example, closing QueueBrowsers during failover has been observed to cause
> issues because it is possible to send the old subscription destination in a
> cancel command to the new broker as the close and failover are allowed to
> progress concurrently. As result of it the broker might close the session
> with a NOT_FOUND execution exception because failover has not finished queue
> re-creation on a new broker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
