[
https://issues.apache.org/jira/browse/QPID-3532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131865#comment-13131865
]
Robbie Gemmell commented on QPID-3532:
--------------------------------------
The testing done is the failover behaviour tests added both before this patch,
and in this patch. There has been no testing in a clustered environment, only
the standalone Java and C++ broker profiles. We are not in a position to test
the cluster, which is why this is up for review and was not simply committed.
What change backouts are you referring to? No changes have been backed out that
I can think of other than 1 trivial revert I did earlier today of some
completely irrelevant code change, which was simply restored to its previous
state because it looked nicer. That did not need reverted, as there was no
functional difference between the two versions, but it looked cleaner the way
it was.
The summary of changes for the patch is as given in the review posting. There
is not a lot to say about it since it is just a small amount of change and
leaves little to really describe.
More tests could be useful, but I am at least happy we do have signficantly
more (i.e > 0) automated tests of the shipping behaviour of the client for
these failover+addressing changes than most of the others made in the past
18months have.
I'm not particularly bothered whether this makes into 0.14 or not, we have just
been sitting on an incomplete version of it for long enough now that it was
time to get it finished and posted :)
> Fix the blocking of JMS operations when failover happens
> --------------------------------------------------------
>
> Key: QPID-3532
> URL: https://issues.apache.org/jira/browse/QPID-3532
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: 0.13
>
> Attachments:
> QPID-3532-make-the-0-10-client-hold-the-failover-mutex-during-failover.patch
>
>
> When connection is lost and failover is started the Qpid Client should block
> on invocation of JMS operations which require sending or receiving data over
> the network.
> With current implementation the performing of certain operations during
> failover can lead to unexpected behaviour.
> For example, closing QueueBrowsers during failover has been observed to cause
> issues because it is possible to send the old subscription destination in a
> cancel command to the new broker as the close and failover are allowed to
> progress concurrently. As result of it the broker might close the session
> with a NOT_FOUND execution exception because failover has not finished queue
> re-creation on a new broker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
