----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3239/#review3964 -----------------------------------------------------------
Oops. Get rid of the braces in THROW_IF_DISPOSED. Effectively the lock goes out of scope before the object protected by the lock is referenced. - Chug On 2011-12-16 21:04:58, Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3239/ > ----------------------------------------------------------- > > (Updated 2011-12-16 21:04:58) > > > Review request for qpid, Andrew Stitcher, Gordon Sim, Ted Ross, Steve Huston, > and Cliff Jansen. > > > Summary > ------- > > QPID-3193 .NET Binding - proper handling of disposed objects. > > > This addresses bug QPID-3193. > https://issues.apache.org/jira/browse/QPID-3193 > > > Diffs > ----- > > trunk/qpid/cpp/bindings/qpid/dotnet/src/BindingCommon.h PRE-CREATION > trunk/qpid/cpp/bindings/qpid/dotnet/src/Message.h 1215245 > trunk/qpid/cpp/bindings/qpid/dotnet/src/Message.cpp 1215245 > > trunk/qpid/cpp/bindings/qpid/dotnet/src/msvc10/org.apache.qpid.messaging.vcxproj > 1215245 > > trunk/qpid/cpp/bindings/qpid/dotnet/src/msvc9/org.apache.qpid.messaging.vcproj > 1215245 > > Diff: https://reviews.apache.org/r/3239/diff > > > Testing > ------- > > > Thanks, > > Chug > >
