-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3239/
-----------------------------------------------------------
(Updated 2011-12-19 22:00:08.704694)
Review request for qpid, Andrew Stitcher, Gordon Sim, Ted Ross, Steve Huston,
and Cliff Jansen.
Changes
-------
Incorporating review comments:
1. Use private lock object and not 'this'. Use same granularity as 'this' - one
lock object per class object.
2. Create a ThrowIfDisposed function so same code is not replicated 40+ times.
3. Any call to destructor or to finalizer deletes unmanaged objects and
effectively disposes of class object. The lock object is not deleted except by
garbage collection.
4. Code is left in macro file to aid maintainability.
Summary
-------
QPID-3193 .NET Binding - proper handling of disposed objects.
This addresses bug QPID-3193.
https://issues.apache.org/jira/browse/QPID-3193
Diffs (updated)
-----
trunk/qpid/cpp/bindings/qpid/dotnet/src/BindingCommon.h PRE-CREATION
trunk/qpid/cpp/bindings/qpid/dotnet/src/Message.h 1215245
trunk/qpid/cpp/bindings/qpid/dotnet/src/Message.cpp 1215245
trunk/qpid/cpp/bindings/qpid/dotnet/src/msvc10/org.apache.qpid.messaging.vcxproj
1215245
trunk/qpid/cpp/bindings/qpid/dotnet/src/msvc9/org.apache.qpid.messaging.vcproj
1215245
Diff: https://reviews.apache.org/r/3239/diff
Testing
-------
Thanks,
Chug
