[
https://issues.apache.org/jira/browse/QPID-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527874#comment-13527874
]
Robbie Gemmell commented on QPID-3317:
--------------------------------------
Regarding http://svn.apache.org/viewvc?view=revision&revision=1418541
All the previous changes relating to this JIRA were part of 0.20, this one is
not. Either this should be requested for merging (after any changes such as the
review below) or it should have a new JIRA to allow properly tracking what the
change is and when it was made.
Given you did multiple commits for particular JIRAs (including this one: see
also http://svn.apache.org/viewvc?view=revision&revision=1418543) back to back
with this commit, is there any particular reason you couldn't separate the
changes so as not to commit two totally unrelated changes to two different
JIRAs at the same time?
The new check below for whether the subscription queue is marked durable when
no queue name was provided seems to be in the wrong place, and performing the
wrong check. Why not throw the exception at the existing point earlier in the
method that we explicitly check whether a queue name was specified, instead of
erroneously assuming that "TempQueue" at the start means the same thing (as
misguided a name as it may seem its perfectly legal for a user to pick that
format for their durable queue names). Did I miss the new tests?
> JMS client doesn't distinguish between node and link bindings
> -------------------------------------------------------------
>
> Key: QPID-3317
> URL: https://issues.apache.org/jira/browse/QPID-3317
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Labels: addressing
>
> The x-bindings specified in node properties should be created/deleted at the
> time the node is created/deleted.
> The x-bindings specified in link properties should be created/deleted at the
> time a link is established to a node.
> Ex creating producer or consumer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
