[ 
https://issues.apache.org/jira/browse/QPID-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528281#comment-13528281
 ] 

Rajith Attapattu commented on QPID-3317:
----------------------------------------

I did ask Justin offline about this, but given he has already got RC2 out and 
given this wasn't a critical issue it was decided to be included in the next 
release.
This change was done as a result of a review comment that was associated with 
the commits I made under that JIRA.
Given it was a very small change I decided to put under the same JIRA as 
opposed to creating a new JIRA which I agree is a mistake in hindsight.
(There is also a comment asking to look at refactoring two methods which I will 
handle as a separate JIRA.)

I do agree that two separate commits would have been better.

I don't think we are performing the wrong check. However I agree that a more 
appropriate place for this check is where we test if the queue name is empty.
If somebody names their queue TempQueue* then they should seriously consider 
the name or marking the queue durable :)
I will move the check to where we test for queue name.
                
> JMS client doesn't distinguish between node and link bindings
> -------------------------------------------------------------
>
>                 Key: QPID-3317
>                 URL: https://issues.apache.org/jira/browse/QPID-3317
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>              Labels: addressing
>
> The x-bindings specified in node properties should be created/deleted at the 
> time the node is created/deleted.
> The x-bindings specified in link properties should be created/deleted at the 
> time a link is established to a node.
> Ex creating producer or consumer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to