[ 
https://issues.apache.org/jira/browse/QPID-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528289#comment-13528289
 ] 

Robbie Gemmell commented on QPID-4497:
--------------------------------------

Not really, no. I don't see that any tests have been added by any of the 
commits under discussion, but changes to affect whether existing tests pass or 
fail were made following bug fixes. This says to me that we are most likely 
still not properly testing something that we should be, or can't really trust 
that the tests are actually correct and passing because the code is working as 
expected too. In particular, if the assertion code wasn't reliable previously 
(which it couldn't have been for that test to pass when it shouldnt) then why 
should we trust it is reliable now if no specific testing was put in place to 
demonstrate the defects it had at the time are fixed now and aren't 
reintroduced in the future?
                
> [Java client] Exclusive property for the subscription queue cannot be 
> overridden using the address string
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4497
>                 URL: https://issues.apache.org/jira/browse/QPID-4497
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.18, 0.20
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>            Priority: Minor
>              Labels: addressing
>             Fix For: 0.21
>
>
> There have been requests to allow the customization of the subscription 
> queue. However there was an issue as the exclusive property wasn't set 
> properly due to a bug.
> amq.topic/test; {link: {name:my-queue, durable:true, 
> x-declare:{exclusive:false, auto-delete:false}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to