[
https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542738#comment-13542738
]
Philip Harvey commented on QPID-3569:
-------------------------------------
My initial thoughts are:
- TransactionTimeoutHelper.check still has quite a lot of duplication, i.e. for
the open and idle paths. Would the current refactoring be a good opportunity to
resolve this duplication? If so, could we change:
{noformat}
final long transactionStartTime = _transaction.getTransactionStartTime();
final long transactionUpdateTime = _transaction.getTransactionUpdateTime();
if (transactionUpdateTime > 0 && transactionStartTime > 0)
{
// do idle and open logic
}
{noformat}
to:
{noformat}
final long transactionStartTime = _transaction.getTransactionStartTime();
if (transactionUpdateTime > 0)
{
// do idle logic
}
final long transactionUpdateTime = _transaction.getTransactionUpdateTime();
if(transactionStartTime > 0)
{
// do open logic
}
{noformat}
- The calls to logIfNecessary in the check(..) method have incorrect indentation
- Do the getTransactionUpdateTime() implementations need an @Override
annotation?
> Refactor TransactionTimeout
> ---------------------------
>
> Key: QPID-3569
> URL: https://issues.apache.org/jira/browse/QPID-3569
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Attachments: 0001-QPID-3569-Refactor-TransactionTimeout.patch
>
>
> The Transaction Timeout feature of the Java Broker relies heavily on system
> tests. It would be better if its implementation were refactored to allow
> more of its functionality to be tested by unit tests and a reduced number of
> system tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
