[ 
https://issues.apache.org/jira/browse/QPID-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543100#comment-13543100
 ] 

Robbie Gemmell commented on QPID-3569:
--------------------------------------

One trivial thing I noted was the use  of an AtomicLong for the update time 
tracking vs a volatile long for the start time tracking. It might be nicer if 
they were both the same, and since we don't use the CAS etc operations from the 
AtomicLong it seems like the volatile long is preferable.
                
> Refactor TransactionTimeout
> ---------------------------
>
>                 Key: QPID-3569
>                 URL: https://issues.apache.org/jira/browse/QPID-3569
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>         Attachments: 0001-QPID-3569-Refactor-TransactionTimeout.patch
>
>
> The Transaction Timeout feature of the Java Broker relies heavily on system 
> tests.  It would be better if its implementation were refactored to allow 
> more of its functionality to be tested by unit tests and a reduced number of 
> system tests. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to