----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9433/#review16579 -----------------------------------------------------------
Looks good. I think the "Testing" section of the top-level README should be amended to mention ctest. http://svn.apache.org/repos/asf/qpid/proton/trunk/CMakeLists.txt <https://reviews.apache.org/r/9433/#comment35167> If I understand correctly, we are only calling Maven from CMake as a short term hack, and in the longer term we'll replace the Maven call with pure CMake configuration. This is so that people without access to Maven can build and test Proton. If I'm correct, then I think this merits a comment here. - Philip Harvey On Feb. 13, 2013, 7:41 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9433/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 7:41 p.m.) > > > Review request for qpid and Mary Hinton. > > > Description > ------- > > The smallest useful example I could devise to illustrate the possibilities. > > See https://issues.apache.org/jira/browse/PROTON-238 for more info > > > This addresses bug PROTON-238. > https://issues.apache.org/jira/browse/PROTON-238 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/qpid/proton/trunk/CMakeLists.txt 1445761 > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt > 1445761 > > Diff: https://reviews.apache.org/r/9433/diff/ > > > Testing > ------- > > linux only so far. Minimally the PYTHONPATH will require a ';' separator in > Windows. > > > Thanks, > > Cliff Jansen > >
