----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9434/#review16600 -----------------------------------------------------------
/proton/trunk/proton-c/include/proton/engine.h <https://reviews.apache.org/r/9434/#comment35221> we should use compiler magic to actually deprecate these if possible /proton/trunk/proton-c/include/proton/engine.h <https://reviews.apache.org/r/9434/#comment35222> likewise here /proton/trunk/proton-c/include/proton/engine.h <https://reviews.apache.org/r/9434/#comment35223> the return code here should be an int and we should update the docs to indicate that the data is always consumed /proton/trunk/proton-c/include/proton/engine.h <https://reviews.apache.org/r/9434/#comment35225> I think we need to add the compliment to this, and I think that will probably influence the naming a tad. Basically we have two methods now. One indicates that no more data will ever be pushed into the tail of the transport, and the other indicates that no more data will ever be popped from the head of the transport. Perhaps pn_transport_close_head() and pn_transport_close_tail(). Closing the tail would mean that no more data can ever be pushed into the tail, i.e. the same thing as push_eos. Closing the head would inform the transport that no more data will ever be popped from the head. This will permit an engine to continue processing input data indefinitely even if the socket output has been shutdown. Without this the engine will always need to assume the socket output is open and could eventually acrue a large enough amount of pending data that it is forced to block forever. For now I think the implementation can ignore close_head, however I think we should have it in the interface and have the driver call it. - Rafael Schloming On Feb. 13, 2013, 8:08 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9434/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 8:08 p.m.) > > > Review request for qpid, Rafael Schloming and Philip Harvey. > > > Description > ------- > > See proton-225 jira. > This only modifies the proton-c transport. > > > This addresses bug proton-225. > https://issues.apache.org/jira/browse/proton-225 > > > Diffs > ----- > > /proton/trunk/proton-c/include/proton/engine.h 1445555 > /proton/trunk/proton-c/src/engine/engine-internal.h 1445555 > /proton/trunk/proton-c/src/engine/engine.c 1445555 > > Diff: https://reviews.apache.org/r/9434/diff/ > > > Testing > ------- > > python unit tests > > > Thanks, > > Kenneth Giusti > >
