> On Feb. 14, 2013, 8:01 p.m., Rafael Schloming wrote: > > /proton/trunk/proton-c/include/proton/engine.h, line 286 > > <https://reviews.apache.org/r/9434/diff/1/?file=258589#file258589line286> > > > > we should use compiler magic to actually deprecate these if possible
Best to do that once the API is available to proton-j also. I've opened PROTON-241 to track this. - Kenneth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9434/#review16600 ----------------------------------------------------------- On Feb. 13, 2013, 8:08 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9434/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 8:08 p.m.) > > > Review request for qpid, Rafael Schloming and Philip Harvey. > > > Description > ------- > > See proton-225 jira. > This only modifies the proton-c transport. > > > This addresses bug proton-225. > https://issues.apache.org/jira/browse/proton-225 > > > Diffs > ----- > > /proton/trunk/proton-c/include/proton/engine.h 1445555 > /proton/trunk/proton-c/src/engine/engine-internal.h 1445555 > /proton/trunk/proton-c/src/engine/engine.c 1445555 > > Diff: https://reviews.apache.org/r/9434/diff/ > > > Testing > ------- > > python unit tests > > > Thanks, > > Kenneth Giusti > >
