-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9503/
-----------------------------------------------------------
(Updated Feb. 18, 2013, 8:58 p.m.)
Review request for qpid, mick goulish, Rafael Schloming, and Philip Harvey.
Changes
-------
Tried to make the analogous changes to the Java Messenger Impl.
I say "tried" because the "testUnlimitedCredit" python unit test almost passes
when the tests are run against proton-j.
I say "almost" because the body of the test actually passes, but the cleanup
times out waiting for the shutdown message to arrive. It's as if credit is not
replenished in time to allow the shutdown.
Invited our Java Friends to have a look.
Description
-------
This implements the "recv(-1) api change: passing -1 to messenger::recv()
causes messenger to grant one credit to every active receiver link.
Note this does not implement the same behavior for the Java implementation of
messenger - not sure even if the same bug is present with that implementation.
This addresses bug proton-200.
https://issues.apache.org/jira/browse/proton-200
Diffs (updated)
-----
/proton/trunk/proton-c/bindings/python/proton.py 1447222
/proton/trunk/proton-c/include/proton/cproton.i 1447222
/proton/trunk/proton-c/include/proton/messenger.h 1447222
/proton/trunk/proton-c/src/messenger.c 1447222
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java
1447222
/proton/trunk/tests/python/proton_tests/messenger.py 1447222
Diff: https://reviews.apache.org/r/9503/diff/
Testing
-------
additional python unit test to exercise this problem.
Thanks,
Kenneth Giusti
