----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9503/#review16765 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Feb. 20, 2013, 2:51 a.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9503/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2013, 2:51 a.m.) > > > Review request for qpid, mick goulish, Rafael Schloming, and Philip Harvey. > > > Description > ------- > > This implements the "recv(-1) api change: passing -1 to messenger::recv() > causes messenger to grant one credit to every active receiver link. > > Note this does not implement the same behavior for the Java implementation of > messenger - not sure even if the same bug is present with that implementation. > > > This addresses bug proton-200. > https://issues.apache.org/jira/browse/proton-200 > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1447222 > /proton/trunk/proton-c/include/proton/cproton.i 1447222 > /proton/trunk/proton-c/include/proton/messenger.h 1447222 > /proton/trunk/proton-c/src/messenger.c 1447222 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java > 1447222 > /proton/trunk/tests/python/proton_tests/messenger.py 1447222 > > Diff: https://reviews.apache.org/r/9503/diff/ > > > Testing > ------- > > additional python unit test to exercise this problem. > > > Thanks, > > Kenneth Giusti > >
