----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10436/#review19108 -----------------------------------------------------------
trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp <https://reviews.apache.org/r/10436/#comment39654> I think there's more code you can remove - getMatch() and the stuff it uses transitively too. trunk/qpid/cpp/src/tests/HeadersExchangeTest.cpp <https://reviews.apache.org/r/10436/#comment39655> Extra whitespace here, which hides the strange layout - put each section terminated by ";" on its own line trunk/qpid/cpp/src/tests/HeadersExchangeTest.cpp <https://reviews.apache.org/r/10436/#comment39659> Here too trunk/qpid/cpp/src/tests/MessageUtils.h <https://reviews.apache.org/r/10436/#comment39656> createMessage() might be a sufficient name - This is actually creating a Message *with* specified application headers. - Andrew Stitcher On April 12, 2013, 9:02 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10436/ > ----------------------------------------------------------- > > (Updated April 12, 2013, 9:02 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Description > ------- > > Code refactor for AMQP 1.0 added new header match logic for headers exchange > but did not update self tests to use it. This patch slightly refactors the > headers exchange logic to create a testable match function. Then it modifies > the self test to call the new function. A single new self test is added to > prove the match four sizes of int and four sizes of uint with each other. > > > This addresses bug QPID-4720. > https://issues.apache.org/jira/browse/QPID-4720 > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1467440 > trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1467440 > trunk/qpid/cpp/src/tests/HeadersExchangeTest.cpp 1467440 > trunk/qpid/cpp/src/tests/MessageUtils.h 1467440 > > Diff: https://reviews.apache.org/r/10436/diff/ > > > Testing > ------- > > The whole object of the patch is test. > > > Thanks, > > Chug Rolke > >
