-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10436/
-----------------------------------------------------------
(Updated April 13, 2013, 2:26 p.m.)
Review request for qpid, Andrew Stitcher and Gordon Sim.
Changes
-------
This diff has createMessage with another bool that allows wholesale replacement
of the applicationHeaders in a message. Before this change appHeaders were set
as strings and not as the rich variety of data types that this code is testing.
Also, the test code calls only createMessage(), answering a review comment.
Adding simple float and double comparisons reveals that float is broken. That
will be raised as a separate Jira.
Description
-------
Code refactor for AMQP 1.0 added new header match logic for headers exchange
but did not update self tests to use it. This patch slightly refactors the
headers exchange logic to create a testable match function. Then it modifies
the self test to call the new function. A single new self test is added to
prove the match four sizes of int and four sizes of uint with each other.
This addresses bug QPID-4720.
https://issues.apache.org/jira/browse/QPID-4720
Diffs (updated)
-----
trunk/qpid/cpp/src/qpid/broker/HeadersExchange.h 1467440
trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1467440
trunk/qpid/cpp/src/tests/HeadersExchangeTest.cpp 1467440
trunk/qpid/cpp/src/tests/MessageUtils.h 1467440
Diff: https://reviews.apache.org/r/10436/diff/
Testing
-------
The whole object of the patch is test.
Thanks,
Chug Rolke
