----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10595/#review19387 -----------------------------------------------------------
I basically like this. I don't see the point of str() added to Duration though given there's operator<< and operator>>. I assume that the options parser uses boost::lexical_cast internally so can automatically take advantage of the new Duration::operator<< which is neat. I'm sure about the introduced new casts perhaps they should be static_cast<>() to make them stand out more? /trunk/qpid/cpp/include/qpid/sys/Time.h <https://reviews.apache.org/r/10595/#comment40098> This isn't used anywhere remove (I don't count testing as somewhere, since it isn't even necessary there) /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp <https://reviews.apache.org/r/10595/#comment40097> Remove - only needed for unnecessary str() /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp <https://reviews.apache.org/r/10595/#comment40096> This doesn't seem to be used anywhere, remove it. - Andrew Stitcher On April 17, 2013, 11:47 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10595/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 11:47 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Description > ------- > > QPID-4748: Consistent handling of durations in broker configuration, allowing > sub-second intervals. > > Allow intervals to be expressed as: > > 10 - value in seconds, backward compatible. > 10s - value in seconds > 10ms - value in milliseconds > 10us - value in microseconds > 10ns - value in nanoseconds > > > This addresses bug QPID-4748. > https://issues.apache.org/jira/browse/QPID-4748 > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/sys/Time.h 1468953 > /trunk/qpid/cpp/src/qpid/broker/Broker.h 1468953 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1468953 > /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1468953 > /trunk/qpid/cpp/src/qpid/ha/StatusCheck.h 1468953 > /trunk/qpid/cpp/src/qpid/ha/StatusCheck.cpp 1468953 > /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp 1468953 > /trunk/qpid/cpp/src/tests/TimerTest.cpp 1468953 > > Diff: https://reviews.apache.org/r/10595/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
