----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10595/#review19393 -----------------------------------------------------------
Ship it! Except for removing the declaration of toTimeval() from PrivatePosix.h I think this is good to go. /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp <https://reviews.apache.org/r/10595/#comment40100> Can get rid of the definition in PrivatePosix.h too. - Andrew Stitcher On April 18, 2013, 4:14 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10595/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 4:14 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Description > ------- > > QPID-4748: Consistent handling of durations in broker configuration, allowing > sub-second intervals. > > Allow intervals to be expressed as: > > 10 - value in seconds, backward compatible. > 10s - value in seconds > 10ms - value in milliseconds > 10us - value in microseconds > 10ns - value in nanoseconds > > > This addresses bug QPID-4748. > https://issues.apache.org/jira/browse/QPID-4748 > > > Diffs > ----- > > /trunk/qpid/cpp/include/qpid/sys/Time.h 1468953 > /trunk/qpid/cpp/src/qpid/broker/Broker.h 1468953 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1468953 > /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1468953 > /trunk/qpid/cpp/src/qpid/ha/Settings.h 1468953 > /trunk/qpid/cpp/src/qpid/ha/StatusCheck.h 1468953 > /trunk/qpid/cpp/src/qpid/ha/StatusCheck.cpp 1468953 > /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp 1468953 > /trunk/qpid/cpp/src/tests/TimerTest.cpp 1468953 > > Diff: https://reviews.apache.org/r/10595/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
