I had a look and it seems reasonable, fixing the issue to the extent possible without substantial change and no apparent impact in other usage of the script which was tested. Windows users will need to quote the value, so I have committed another tiny change to update the docs/help to reflect that.
Robbie On 24 May 2013 11:40, Justin Ross <[email protected]> wrote: > I don't really object to including this. Can we have someone with > batch script skills take a quick look at it? > > Justin > > On Thu, May 23, 2013 at 6:28 PM, Oleksandr Rudyy <[email protected]> wrote: > > Justin, > > > > I hope it is still not too late to request the inclusion into 0.22 of a > > minor fix for Windows batch script to start Java Broker ( > > http://svn.apache.org/r1485859 QPID-4881). > > > > We introduced new command line arguments requiring to pass an equal > > character as part of the argument but the batch script splits the command > > line argument with 'equal' into two arguments and removes equal > character. > > Such arguments have to be quoted but processing of quoted arguments > > resulted in the errors. > > > > The changes fixed the processing of quoted arguments. It is a minor issue > > and there are some workarounds but I would like to request the inclusion > of > > the fix as it is quite trivial. > > > > Kind Regards, > > Alex > > > > > > > > On 23 May 2013 22:40, Ken Giusti <[email protected]> wrote: > > > >> Justin, > >> > >> A new RC, you say? > >> > >> Well, I'll just leave this little tidbit here, ya know, just in case: > >> > >> https://issues.apache.org/jira/browse/QPID-4883 > >> > >> /backs slowly away from my keyboard.... > >> > >> > >> > >> ----- Original Message ----- > >> > From: "Justin Ross" <[email protected]> > >> > To: [email protected] > >> > Sent: Thursday, May 23, 2013 10:34:58 AM > >> > Subject: Re: [VOTE] Release 0.22 > >> > > >> > This vote is withdrawn. We'll have a new RC later today. The only > >> > new change will be the cmake build fix. Once that's available, I'll > >> > start a new vote thread. > >> > > >> > Justin > >> > > >> > On Wed, May 22, 2013 at 5:14 PM, Justin Ross <[email protected]> > wrote: > >> > > Okay, we'll fix it tomorrow. > >> > > > >> > > On May 22, 2013 4:09 PM, "Darryl L. Pierce" <[email protected]> > >> wrote: > >> > >> > >> > >> On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: > >> > >> > RC5 contains the proposed final bits for Qpid 0.22. > >> > >> > > >> > >> > If you favor making the RC5 bits into our official release, vote > +1. > >> > >> > If you have reason to believe RC5 is not ready for release, vote > -1. > >> > >> > > >> > >> > I will close this vote on Monday, 22 May. I know that's a little > >> > >> > brief, but I have some vacation time coming up soon, and I'm > hoping > >> to > >> > >> > finish the release before I leave. > >> > >> > >> > >> The patches for 4344 were applied in reverse on this branch and, > with > >> > >> the last cherry-pick, the bindings/CMakeLists.txt broke the CMake > >> > >> changes. The conditional check for Swig < 1.3.32 is still in the > file > >> > >> and needs to be deleted to fix CMake. > >> > >> > >> > >> This is totally my fault. > >> > >> > >> > >> -- > >> > >> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > >> > >> Delivering value year after year. > >> > >> Red Hat ranks #1 in value among software vendors. > >> > >> http://www.redhat.com/promo/vendor/ > >> > >> > >> > > > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: [email protected] > >> > For additional commands, e-mail: [email protected] > >> > > >> > > >> > >> -- > >> -K > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
