On 07/09/2013 08:34 PM, Darryl L. Pierce wrote:
One of the issues that needs to be fixed for this is the package name
for the code. Currently it's "cqpid", which isn't close to what we have
in other languages (which all use a variable on qpid.messaging).
However, we can't use that since it's what our pure Python code uses.
Or can we?
I don't think we should. They should each have their own name to clearly
identify them (the name refers to the implementation, not just the API
as it does in say c++).
I agree that cqpid is not a good name for the swigged module; it is too
ambiguous. I would suggest something like qpidc_messaging or
qpid_cmessaging instead. However changes such as those need to be
discussed on the user list.
That's the question: how do we package up the code? I've experimented
with the examples we have and they seem to work just fine with cqpid
substituted for qpid.messaging for the imports.
I have been working to get (at least some of) the python tests running
over the swigged implementation. My motivation here was initially to add
some new tests for the AMQP 1.0 functionality using python. However it
would also be desirable to be able to run some of the existing tests
over 1.0 as well as continuing to be able to run over 0-10.
I hope to have a patch up for review before too long, but by adding
another module (I called it qpid_messaging.py) that tries to import from
the swigged module, then falls back to importing qpid.messaging, I was
able to have one import statement in tests of interest and then run them
over either swigged or pure implementations based on whether the former
was on the path or not.
So in this scheme you have qpid.messaging for the exiting, pure python
implementation (only supports 0-10 at present), cqpid (which I agree is
a poor name, but see above) for the swigged implementation that supports
0-10 and 1.0, and qpid_messaging that can be used in contexts where
switching between the two without editing files is desirable (e.g. tests
and perhaps examples).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
