----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14781/#review27243 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp <https://reviews.apache.org/r/14781/#comment53057> Doesn't make any difference in behavior but I think the intent is clearer if you put lock.notifyAll after incoming->close since notified threads can't do anything until the mutex is released. /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp <https://reviews.apache.org/r/14781/#comment53058> I don't get this, why re-open incoming here? - Alan Conway On Oct. 21, 2013, 12:01 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14781/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 12:01 p.m.) > > > Review request for qpid and Alan Conway. > > > Bugs: QPID-4265 > https://issues.apache.org/jira/browse/QPID-4265 > > > Repository: qpid > > > Description > ------- > > If one thread is in a fetch() on a receiver using Duration::FOREVER, closing > that receiver doesn't stop the fetch. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1534108 > /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1534108 > /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1534108 > > Diff: https://reviews.apache.org/r/14781/diff/ > > > Testing > ------- > > make test passes > > > Thanks, > > Gordon Sim > >
