> On Oct. 21, 2013, 2 p.m., Alan Conway wrote:
> > /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp, line 164
> > <https://reviews.apache.org/r/14781/diff/1/?file=368554#file368554line164>
> >
> >     Doesn't make any difference in behavior but I think the intent is 
> > clearer if you put lock.notifyAll after incoming->close since notified 
> > threads can't do anything until the mutex is released.

Done


> On Oct. 21, 2013, 2 p.m., Alan Conway wrote:
> > /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp, line 267
> > <https://reviews.apache.org/r/14781/diff/1/?file=368554#file368554line267>
> >
> >     I don't get this, why re-open incoming here?

Because the incoming queue is session-wide, and only the receiver has been 
closed. I don't really want to 'close' the queue, just to wakeup the thread 
blocked on pop().


- Gordon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14781/#review27243
-----------------------------------------------------------


On Oct. 21, 2013, 2:11 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14781/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 2:11 p.m.)
> 
> 
> Review request for qpid and Alan Conway.
> 
> 
> Bugs: QPID-4265
>     https://issues.apache.org/jira/browse/QPID-4265
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> If one thread is in a fetch() on a receiver using Duration::FOREVER, closing 
> that receiver doesn't stop the fetch.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1534108 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1534108 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1534108 
> 
> Diff: https://reviews.apache.org/r/14781/diff/
> 
> 
> Testing
> -------
> 
> make test passes
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

Reply via email to