-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14882/#review27523
-----------------------------------------------------------


Hi Gordon,

Some comments from my side ...

- is there a possibility to configure the Queue Policy to create auto-delete 
queues? It seems that you always create the queues as autodelete=false

- The qpidt tool seems to ignore the type when deleting the policy. You can 
delete the topic policy with command "qpidt delete QueuePolicy 
<topic-policy-name>

- The qpidt tool you created for configuring topics and policies is located in 
my build in /usr/local/libexec/qpid/tests/qpidt. Is that some bug in my build 
or is that intended? I assume one can configure them over QMF from any program. 
But it would be nice to have a configuration utility to configure them from 
command line - either using qpid-config or by moving the qpidt to a /usr/bin 
directory to make it a bit easier to find

- Last but not least, the broker seems to crash when a client which used the 
Topic Policy disconnects. I used topic policy created like this:
qpidt create TopicPolicy response.* durable=true exchange=response
and a client which created receiver:
response.ABCFR_ABCFRALMMACC1.591ec10a-4d57-4b8c-ba32-7eb1eaeb3686; { create: 
never, node: { type: 'queue' } }
The broker seems to crash when I close the receiver.

Regards
Jakub

- Jakub Scholz


On Oct. 23, 2013, 7:56 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14882/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 7:56 p.m.)
> 
> 
> Review request for qpid, Kenneth Giusti and Ted Ross.
> 
> 
> Bugs: QPID-5251
>     https://issues.apache.org/jira/browse/QPID-5251
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> This adds the ability to create QueuePolicy or TopicPolicy instances that 
> enable on demand creation of queues or topics respectively for any name that 
> fails to resolve to an existing queue/exchange/topic and matches the pattern 
> on a defined policy.
> 
> The primary mechanism for managing these policies is through the QMF 
> create/delete methods. E.g using the qpidt utility:
> 
>   qpidt create QueuePolicy dynamic-queue-*
> 
> will create a queue policy with the pattern dynamic-queue-*, so that any 
> attempt to link to a node that matches that pattern (i.e. starts with 
> dynamic-queue-), e,g, dynamic-queue-abc, will result in the queue being 
> created on demand. Other options can be specified for the policy and those 
> will be used when creating the node.
> 
> In addition I've added a couple of 1.0 related command line options to qpidd 
> - queue-pattern and topic-pattern - so that for the simple cases you can 
> specify the desired behaviour when starting qpidd up. E.g. 
> 
>  ./src/qpidd --auth no  --load-module ./src/amqp.so --queue-pattern 
> 'dynamic.\queues\.*' --topic-pattern 'dynamic\.topics\.*'
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/amqp.cmake 1535048 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/BrokerContext.h 1535048 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/BrokerContext.cpp 1535048 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.h PRE-CREATION 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.cpp PRE-CREATION 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/ProtocolPlugin.cpp 1535048 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1535048 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/Topic.h 1535048 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/Topic.cpp 1535048 
>   /trunk/qpid/cpp/src/qpid/sys/regex.h 1535048 
>   /trunk/qpid/specs/management-schema.xml 1535048 
> 
> Diff: https://reviews.apache.org/r/14882/diff/
> 
> 
> Testing
> -------
> 
> Minimal.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

Reply via email to