-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14882/#review27771
-----------------------------------------------------------



/trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.cpp
<https://reviews.apache.org/r/14882/#comment53970>

    My brain just stack dumped - durable is set to true if AUTO_DELETE is 
explicitly specified and true.  Seems counter-intuitive to me, can you add a 
comment explaining the intent?



/trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.cpp
<https://reviews.apache.org/r/14882/#comment53967>

    Doesn't filterForQueue() erase AUTO_DELETE, making 
filtered.find(AUTO_DELETE) always == filtered.end()?


- Kenneth Giusti


On Oct. 30, 2013, 11:27 a.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14882/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 11:27 a.m.)
> 
> 
> Review request for qpid, Kenneth Giusti and Ted Ross.
> 
> 
> Bugs: QPID-5251
>     https://issues.apache.org/jira/browse/QPID-5251
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> This adds the ability to create QueuePolicy or TopicPolicy instances that 
> enable on demand creation of queues or topics respectively for any name that 
> fails to resolve to an existing queue/exchange/topic and matches the pattern 
> on a defined policy.
> 
> The primary mechanism for managing these policies is through the QMF 
> create/delete methods. E.g using the qpidt utility:
> 
>   qpidt create QueuePolicy dynamic-queue-*
> 
> will create a queue policy with the pattern dynamic-queue-*, so that any 
> attempt to link to a node that matches that pattern (i.e. starts with 
> dynamic-queue-), e,g, dynamic-queue-abc, will result in the queue being 
> created on demand. Other options can be specified for the policy and those 
> will be used when creating the node.
> 
> In addition I've added a couple of 1.0 related command line options to qpidd 
> - queue-pattern and topic-pattern - so that for the simple cases you can 
> specify the desired behaviour when starting qpidd up. E.g. 
> 
>  ./src/qpidd --auth no  --load-module ./src/amqp.so --queue-pattern 
> 'dynamic.\queues\.*' --topic-pattern 'dynamic\.topics\.*'
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/amqp.cmake 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/PersistableObject.h 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/PersistableObject.cpp 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/BrokerContext.h 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/BrokerContext.cpp 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.h PRE-CREATION 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.cpp PRE-CREATION 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/ProtocolPlugin.cpp 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/Topic.h 1536223 
>   /trunk/qpid/cpp/src/qpid/broker/amqp/Topic.cpp 1536223 
>   /trunk/qpid/cpp/src/qpid/sys/regex.h 1536223 
>   /trunk/qpid/cpp/src/tests/policies.py PRE-CREATION 
>   /trunk/qpid/cpp/src/tests/swig_python_tests 1536223 
>   /trunk/qpid/specs/management-schema.xml 1536223 
> 
> Diff: https://reviews.apache.org/r/14882/diff/
> 
> 
> Testing
> -------
> 
> Minimal.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

Reply via email to