----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15353/#review28552 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/DataDir.cpp <https://reviews.apache.org/r/15353/#comment55351> I'm not sure I see the need for changing the DataDir class: Can't you just make the pagingDir another instance of a DataDir? /trunk/qpid/cpp/src/qpid/DataDir.cpp <https://reviews.apache.org/r/15353/#comment55350> I think moving the code to actually create the data directory into the "create lockfile" code isn't the correct division of functionality. - Andrew Stitcher On Nov. 8, 2013, 5:44 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15353/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 5:44 p.m.) > > > Review request for qpid. > > > Bugs: QPID-5316 > https://issues.apache.org/jira/browse/QPID-5316 > > > Repository: qpid > > > Description > ------- > > Adds a new option as suggested on user list, in order to control where the > paging files go speartely from the other data-dir stuff. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/DataDir.h 1540138 > /trunk/qpid/cpp/src/qpid/DataDir.cpp 1540138 > /trunk/qpid/cpp/src/qpid/broker/Broker.h 1540138 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1540138 > /trunk/qpid/cpp/src/qpid/broker/QueueFactory.cpp 1540138 > > Diff: https://reviews.apache.org/r/15353/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
