----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/#review29373 -----------------------------------------------------------
/trunk/qpid/cpp/include/qmf/Agent.h <https://reviews.apache.org/r/15788/#comment56570> For the sake of DRY could you put these lines in qmf/ImportExport.h? It's not a blocking issue, my eye is just offended by so much repetition. /trunk/qpid/cpp/include/qmf/SchemaTypes.h <https://reviews.apache.org/r/15788/#comment56571> Looks like this is the only block that doesn't precede an include of qmf/ImportExport.h, so perhaps move the error in there and replace this with #include "qmf/ImportExport.h" - Andrew Stitcher On Nov. 22, 2013, 9:01 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15788/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 9:01 p.m.) > > > Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross. > > > Bugs: qpid-5369 > https://issues.apache.org/jira/browse/qpid-5369 > > > Repository: qpid > > > Description > ------- > > Causes any application that includes the QMF Agent or Console C++ headers to > issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the > application. > > The compiler error reads: > > In file included from > /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0: > /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: > #error "The API defined in this file has been DEPRECATED and will be removed > in the future." > /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: > #error "Define 'QMF_USE_DEPRECATED_API' to disable this error." > > Note: I'd like to propose this gets in for 0.26 - if you agree please comment > as such on the JIRA, thanks. > > > Diffs > ----- > > /trunk/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp 1543123 > /trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp > 1543123 > /trunk/qpid/cpp/bindings/qmf2/examples/cpp/list_agents.cpp 1543123 > /trunk/qpid/cpp/bindings/qmf2/examples/cpp/print_events.cpp 1543123 > /trunk/qpid/cpp/include/qmf/Agent.h 1543123 > /trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123 > /trunk/qpid/cpp/include/qmf/AgentSession.h 1543123 > /trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123 > /trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123 > /trunk/qpid/cpp/include/qmf/Data.h 1543123 > /trunk/qpid/cpp/include/qmf/DataAddr.h 1543123 > /trunk/qpid/cpp/include/qmf/Handle.h 1543123 > /trunk/qpid/cpp/include/qmf/Query.h 1543123 > /trunk/qpid/cpp/include/qmf/Schema.h 1543123 > /trunk/qpid/cpp/include/qmf/SchemaId.h 1543123 > /trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123 > /trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123 > /trunk/qpid/cpp/include/qmf/SchemaTypes.h 1543123 > /trunk/qpid/cpp/include/qmf/Subscription.h 1543123 > /trunk/qpid/cpp/include/qmf/exceptions.h 1543123 > /trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123 > /trunk/qpid/cpp/include/qmf/qmf2.i 1543123 > > Diff: https://reviews.apache.org/r/15788/diff/ > > > Testing > ------- > > Tested on windows (VS 2010) and linux (Fedora 18), both with and without > QMF_USE_DEPRECATED_API defined. > > > Thanks, > > Kenneth Giusti > >
