----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15788/#review29442 -----------------------------------------------------------
This looks good to me (but I'm not a python or ruby expert). Did you intend to make the warning unconditional though? It seems there is no way to turn it off if you "know what you are doing". That might be a little alarming to end users of a program that uses it. - Andrew Stitcher On Nov. 26, 2013, 4:52 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15788/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 4:52 p.m.) > > > Review request for qpid and Justin Ross. > > > Bugs: qpid-5369 > https://issues.apache.org/jira/browse/qpid-5369 > > > Repository: qpid > > > Description > ------- > > Causes any application that includes the QMF Agent or Console C++ headers to > issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the > application. > > The compiler error reads: > > In file included from > /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0: > /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: > #error "The API defined in this file has been DEPRECATED and will be removed > in the future." > /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: > #error "Define 'QMF_USE_DEPRECATED_API' to disable this error." > > Note: I'd like to propose this gets in for 0.26 - if you agree please comment > as such on the JIRA, thanks. > > > Diffs > ----- > > /trunk/qpid/cpp/bindings/qmf2/python/qmf2.py 1545563 > /trunk/qpid/cpp/bindings/qmf2/ruby/qmf2.rb 1545563 > > Diff: https://reviews.apache.org/r/15788/diff/ > > > Testing > ------- > > Tested on windows (VS 2010) and linux (Fedora 18), both with and without > QMF_USE_DEPRECATED_API defined. > > > Thanks, > > Kenneth Giusti > >
