----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19792/#review38929 -----------------------------------------------------------
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp <https://reviews.apache.org/r/19792/#comment71267> Where does "protocol" come from here? Shouldn't TCP always be the default protocol, or is there some other means of specifying a default? - Alan Conway On March 28, 2014, 6:37 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19792/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 6:37 p.m.) > > > Review request for qpid and Alan Conway. > > > Bugs: QPID-5648 > https://issues.apache.org/jira/browse/QPID-5648 > > > Repository: qpid > > > Description > ------- > > Previous QPID-5568 refactored code that resulted in lost ssl processing logic > for amqp1.0 clients. > > This restores the ConnectionSettings protocol into the parsed url. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp > 1582846 > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/urlAdd.h > 1582846 > > Diff: https://reviews.apache.org/r/19792/diff/ > > > Testing > ------- > > ctest > > > Thanks, > > Cliff Jansen > >
