> On March 28, 2014, 6:47 p.m., Alan Conway wrote:
> > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp,
> > line 81
> > <https://reviews.apache.org/r/19792/diff/1/?file=539871#file539871line81>
> >
> > Where does "protocol" come from here?
> >
> > Shouldn't TCP always be the default protocol, or is there some other
> > means of specifying a default?
It comes from the ConnectionSettings for the connection. In this case the
qpid::messaging::ConnectionOptions is a superclass of ConnectionSettings.
here is the relevant code from the old version of ConnectionContext that you
removed:
bool ConnectionContext::tryConnect()
{
for (std::vector<std::string>::const_iterator i = urls.begin(); i !=
urls.end(); ++i) {
try {
QPID_LOG(info, "Trying to connect to " << *i << "...");
if (tryConnect(qpid::Url(*i, protocol.empty() ? qpid::Address::TCP
: protocol))) {
return true;
}
QPID_LOG(info, "Failed to connect to " << *i);
} catch (const qpid::messaging::TransportFailure& e) {
QPID_LOG(info, "Failed to connect to " << *i << ": " << e.what());
}
}
return false;
}
- Cliff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19792/#review38929
-----------------------------------------------------------
On March 28, 2014, 6:37 p.m., Cliff Jansen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19792/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 6:37 p.m.)
>
>
> Review request for qpid and Alan Conway.
>
>
> Bugs: QPID-5648
> https://issues.apache.org/jira/browse/QPID-5648
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Previous QPID-5568 refactored code that resulted in lost ssl processing logic
> for amqp1.0 clients.
>
> This restores the ConnectionSettings protocol into the parsed url.
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp
> 1582846
> http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/urlAdd.h
> 1582846
>
> Diff: https://reviews.apache.org/r/19792/diff/
>
>
> Testing
> -------
>
> ctest
>
>
> Thanks,
>
> Cliff Jansen
>
>
