[
https://issues.apache.org/jira/browse/QPID-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979649#comment-13979649
]
Keith Wall commented on QPID-5580:
----------------------------------
I've reviewed the commit at r1588234, here are my minor comments:
# AbstractQueue#getCreateTime and _createTime and its TODO are redundant.
# AbstractQueue.QPID_NO_GROUP is dead. It has been replaced by a
@ManagedContextDefault
# AbstractQueue#validate - the change listener seems to be a no-op. In fact
the whole validate() method seems to be effectively a noop (name is mandatory
and queue can't exist without a virtual host parent).
# Should AbstractQueue override toString with name? I think the
specialisations (PriorityQueue) should override and include the interesting
attributes numberOfPriorities etc
> [Java Broker] Allow explicit hierarchy of specialisations of configured
> objects (e.g PriorityQueue is a type of Queue)
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-5580
> URL: https://issues.apache.org/jira/browse/QPID-5580
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
>
> The broker already has ad-hoc implementations of hierarchies or sub-types
> (e.g. virtualhosts and authentication providers) where the specific
> implementations allow different attributes and different operations. The
> hierarchy mechanism should be made generic and compatible with AMQP
> management
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
