[
https://issues.apache.org/jira/browse/QPID-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982378#comment-13982378
]
Alex Rudyy commented on QPID-5665:
----------------------------------
He Rob,
Here are my review comments:
* AVH#createTime looks like redundant to me. It is not used anywhere.
org.apache.qpid.server.virtualhost.AbstractVirtualHost.getCreateTime()
* AVH calls static method SecurityManager.getSubjectWithAddedSystemRights()
using instance of security manager
getSecurityManager().getSubjectWithAddedSystemRights()
* Dead code:
org.apache.qpid.server.virtualhost.AbstractVirtualHost.setType(String, String)
* org.apache.qpid.server.virtualhost.AbstractVirtualHost.getChildren(Class<C>)
Should it also have code to return queues and exchanges?
* org.apache.qpid.server.virtualhost.AbstractVirtualHost.createExchange(String,
State, boolean, LifetimePolicy, String, Map<String, Object>)
* An optimization can be made in
{code}
else if(altExchangeObject instanceof UUID)
{
for(Exchange ex : getExchanges())
{
if(altExchangeObject.equals(ex.getId()))
{
alternateExchange = ex.getName();
break;
}
}
}
{code}
The for loop can be replaced with
{code}
Exchange ex = getExchange(altExchangeObject);
if (ex != null)
{
alternateExchange = ex.getName();
}
{code}
* The following 2 loops can be replaced with corresponding method calls.
* It seems that attribute "getSupportedQueueTypes" in
org.apache.qpid.server.virtualhost.AbstractVirtualHost.getAttribute(String) can
be evaluated now.
* I wonder whether class
org.apache.qpid.server.model.adapter.VirtualHostAliasAdapter can be renamed
into VirtualHostAliasImpl
> [Java Broker] VirtualHost implementations should directly implement the model
> interface
> ---------------------------------------------------------------------------------------
>
> Key: QPID-5665
> URL: https://issues.apache.org/jira/browse/QPID-5665
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
>
> The VirtualHost object is the last significant durable configured object
> which uses an adapter to provide the model interface. VirtualHost and
> VirtualHostAdapter should be combined such that there is no longer a
> distinction between the model object and the implementation
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
