[
https://issues.apache.org/jira/browse/QPID-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982907#comment-13982907
]
Rob Godfrey commented on QPID-5665:
-----------------------------------
{quote}
AVH calls static method SecurityManager.getSubjectWithAddedSystemRights() using
instance of security manager
getSecurityManager().getSubjectWithAddedSystemRights()
{quote}
I'd like to move that to be a non static method some time :-)
{quote}
org.apache.qpid.server.virtualhost.AbstractVirtualHost.getChildren(Class<C>)
Should it also have code to return queues and exchanges?
{quote}
the call to super.getChildren() does that. Ideally all getChildren() calls
could be handled by AbstractConfiguredObject...
{quote}
org.apache.qpid.server.virtualhost.AbstractVirtualHost.createExchange(String,
State, boolean, LifetimePolicy, String, Map<String, Object>)
{quote}
even better, that method can be removed and a call made to
createExchange(Map<String,Object> attributes) instead... which is what I have
done :-)
{quote}
I wonder whether class
org.apache.qpid.server.model.adapter.VirtualHostAliasAdapter can be renamed
into VirtualHostAliasImpl
{quote}
When I fix VirtualHostAliases I'll name the class properly... however they're
really not real things at the moment :(
> [Java Broker] VirtualHost implementations should directly implement the model
> interface
> ---------------------------------------------------------------------------------------
>
> Key: QPID-5665
> URL: https://issues.apache.org/jira/browse/QPID-5665
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
>
> The VirtualHost object is the last significant durable configured object
> which uses an adapter to provide the model interface. VirtualHost and
> VirtualHostAdapter should be combined such that there is no longer a
> distinction between the model object and the implementation
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
