-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22273/
-----------------------------------------------------------

Review request for qpid and Rafael Schloming.


Bugs: PROTON-595
    https://issues.apache.org/jira/browse/PROTON-595


Repository: qpid


Description
-------

Popen(file.py, ...) needs to run with shell=True on windows. On Linux the tests 
hang when shell=True. This patch compromises by turning on the shell arg when 
running on windows.

Change the arg list to run Popen(python, file.py, ...) touches wider ranges of 
source code with some risk and with no obvious benefit.


Diffs
-----


Diff: https://reviews.apache.org/r/22273/diff/


Testing
-------

Passes tests on linux and windows.


Thanks,

Chug Rolke

Reply via email to