-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22273/
-----------------------------------------------------------
(Updated June 11, 2014, 2:13 p.m.)
Review request for qpid and Rafael Schloming.
Changes
-------
Responding to Andrew's suggestion this patch makes launching a python script on
Windows a special case. Then the test resolves the absolute path of the script
file and changes the launch pattern from <scriptname.py> to <python,
abs-path-to-scriptname.py>. The Popen call is restored to the original form for
both windows and not windows.
Note that the pattern <python, scriptname.py> fails in all Popen calls. Either
the PATH environment is not passed to the subprocess or the spawned python
process doesn't bother searching the path for scriptname.py. Python searches
for scriptname.py in one place (<build-dir>\proton-c\) and fails because the
script is never there. Finding the absolute path to the file while in the
calling test process seems like the most reliable way to go.
Bugs: PROTON-595
https://issues.apache.org/jira/browse/PROTON-595
Repository: qpid
Description
-------
Popen(file.py, ...) needs to run with shell=True on windows. On Linux the tests
hang when shell=True. This patch compromises by turning on the shell arg when
running on windows.
Change the arg list to run Popen(python, file.py, ...) touches wider ranges of
source code with some risk and with no obvious benefit.
Diffs (updated)
-----
proton/trunk/tests/python/proton_tests/common.py 1601492
Diff: https://reviews.apache.org/r/22273/diff/
Testing
-------
Passes tests on linux and windows.
Thanks,
Chug Rolke
